Add installation step for Kubernetes 1.34 with Helm 3.19.0#830
Add installation step for Kubernetes 1.34 with Helm 3.19.0#830Ngwerume wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new CircleCI workflow job, install_k8s-1.34_helm-3.19.0, to test Helm installations on Kubernetes version 1.34. However, the feedback highlights that Kubernetes 1.34 has not been released yet, meaning the 1.34/stable MicroK8s channel does not exist and will cause the workflow to fail.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| name: install_k8s-1.34_helm-3.19.0 | ||
| helm_repo: "https://charts.codacy.com/incubator" | ||
| chart_version: $(cat .version) | ||
| microk8s_channel: "1.34/stable" |
There was a problem hiding this comment.
The MicroK8s channel 1.34/stable does not exist yet because Kubernetes 1.34 has not been released. Attempting to run this workflow will cause the install_k8s-1.34_helm-3.19.0 job to fail. Please verify if this addition is premature or if a pre-release channel should be used instead.
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
The PR correctly adds the 'install_k8s-1.34_helm-3.19.0' job to the CircleCI workflow, utilizing the '1.34/stable' microk8s channel and Helm version 'v3.19.0'. The manual release gates (manual_qa_hold and manual_solutions_eng_hold) have been properly updated to depend on this new installation step. Codacy analysis indicates the changes are up to standards with no new issues or complexity concerns.
While the technical implementation is sound, the PR lacks a description. This documentation is important for confirming that Kubernetes 1.34 and Helm 3.19.0 have been validated for official support with the current charts.
About this PR
- The PR description is empty. Please provide context for this upgrade and confirm if Kubernetes 1.34 and Helm 3.19.0 are officially supported and tested for compatibility with the current project structure.
Test suggestions
- Verify 'install_k8s-1.34_helm-3.19.0' job configuration correctly sets microk8s_channel to '1.34/stable' and helm_version to 'v3.19.0'.
- Verify 'manual_qa_hold' depends on the success of the new Kubernetes 1.34 install job.
- Verify 'manual_solutions_eng_hold' depends on the success of the new Kubernetes 1.34 install job.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
1 participant
No description provided.